Changed term 'control' to 'requirement' on the UI #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#276) * New frontend component to display the original SRG information for a Rule * Display NIST Control and CCI since that information does not come from SRG * When method is found to link original SRG information to a control, the placeholder fields need to be hooked up. * eslint
…of project prefix + database ID (#279) This makes it possible to maintain rule IDs across duplications since the ID does not have to be unique across the whole project. This works towards closing #278 however since the duplicate functionality does not currently work it does not fully complete the work that has to be done.
* Add ability to duplicate and version projects This hooks up the backend to support duplicating projects. It also ensures that controls IDs (STIG IDs) are maintained across revisions. Closes #136, #278 * Remove direct calls to 'nist_control_family' and add it to the base as_json method * Rewrite largest_rule_id to work properly, it was previously just returning the highest database ID
Co-authored-by: Tim Wong <[email protected]>
Co-authored-by: Robert Clark <[email protected]>
…290) Co-authored-by: Robert Clark <[email protected]>
* Add support for arbitrary fields on Components * Add support for cloning answers when cloning a component * Run rubocop * Ensure that no more than 1 answer can be created per question and rule ID combo * Run eslint * Additional fixes for 'Configurable - Duplicate', fixes #293 * Do not allow status to change while the control is satisfied by another control
Co-authored-by: Robert Clark <[email protected]>
) Co-authored-by: Robert Clark <[email protected]>
Co-authored-by: Robert Clark <[email protected]>
* Upgrade to ruby 2.7.5 * Upgrade gems
This has the unfortunate effect of triggering the popup blocker but does at least avoid base64 encoding.
This makes it easier to open additional controls without requiring the user to scroll up and down the page.
Move review dropdown to always stick to the right side of the page in order to avoid having to keep the sidebar so large. Increase sidebar padding to avoid text getting hidden under the scrollbar.
VULCAN-447: Enable context-aware popover help icons, depending on Status field
VULCAN-448: Add concept of compensating controls and POA&M statuses to Applicable - Does Not Meet status
VULCAN-452: Review workflow improvements
VULCAN-448: mitigations are always shown
Signed-off-by: Will Dower <[email protected]>
Signed-off-by: Christopher Hinchey <[email protected]>
Add GitHub logo to README
Signed-off-by: Christopher Hinchey <[email protected]>
Fix GitHub logo in README
* Added custom button variant Signed-off-by: Vanessa Fotso <[email protected]> * Changed bg color for 'mark as duplicate' button Signed-off-by: Vanessa Fotso <[email protected]> * Cleanup unused classes Signed-off-by: Vanessa Fotso <[email protected]> Signed-off-by: Vanessa Fotso <[email protected]>
Signed-off-by: Vanessa Fotso <[email protected]>
aaronlippold
approved these changes
Jun 5, 2023
|
I am good with merging this and closing it out. What do folks think? |
There was a problem hiding this comment.
Copilot reviewed 5 out of 19 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- app/javascript/components/rules/RuleEditorHeader.vue: Evaluated as low risk
- app/javascript/components/rules/forms/RuleForm.vue: Evaluated as low risk
- app/javascript/components/rules/RuleNavigator.vue: Evaluated as low risk
- app/javascript/components/components/NewComponentModal.vue: Evaluated as low risk
- app/javascript/components/components/ProjectComponent.vue: Evaluated as low risk
- app/javascript/components/memberships/NewMembership.vue: Evaluated as low risk
- app/javascript/components/rules/FindAndReplace.vue: Evaluated as low risk
- app/javascript/components/rules/FindAndReplaceResult.vue: Evaluated as low risk
- app/javascript/components/components/LockControlsModal.vue: Evaluated as low risk
- app/javascript/components/components/ComponentCard.vue: Evaluated as low risk
- app/javascript/components/rules/Rules.vue: Evaluated as low risk
- app/javascript/components/rules/RuleSatisfactions.vue: Evaluated as low risk
- app/javascript/components/rules/RulesCodeEditorView.vue: Evaluated as low risk
- app/javascript/components/rules/RulesReadOnlyView.vue: Evaluated as low risk
Amndeep7
force-pushed
the
487-terminology-change-differentiate-security-controls-from-security-requirements
branch
from
695f4f2 to
fda7d4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vanessa Fotso [email protected]